001////////////////////////////////////////////////////////////////////////////////
002// checkstyle: Checks Java source code for adherence to a set of rules.
003// Copyright (C) 2001-2018 the original author or authors.
004//
005// This library is free software; you can redistribute it and/or
006// modify it under the terms of the GNU Lesser General Public
007// License as published by the Free Software Foundation; either
008// version 2.1 of the License, or (at your option) any later version.
009//
010// This library is distributed in the hope that it will be useful,
011// but WITHOUT ANY WARRANTY; without even the implied warranty of
012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
013// Lesser General Public License for more details.
014//
015// You should have received a copy of the GNU Lesser General Public
016// License along with this library; if not, write to the Free Software
017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
018////////////////////////////////////////////////////////////////////////////////
019
020package com.puppycrawl.tools.checkstyle.checks.coding;
021
022import java.util.Arrays;
023
024import com.puppycrawl.tools.checkstyle.StatelessCheck;
025import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
026import com.puppycrawl.tools.checkstyle.api.DetailAST;
027import com.puppycrawl.tools.checkstyle.api.TokenTypes;
028import com.puppycrawl.tools.checkstyle.utils.CheckUtils;
029import com.puppycrawl.tools.checkstyle.utils.CommonUtils;
030import com.puppycrawl.tools.checkstyle.utils.ScopeUtils;
031import com.puppycrawl.tools.checkstyle.utils.TokenUtils;
032
033/**
034 * <p>
035 * Checks that there are no <a href="https://en.wikipedia.org/wiki/Magic_number_%28programming%29">
036 * &quot;magic numbers&quot;</a> where a magic
037 * number is a numeric literal that is not defined as a constant.
038 * By default, -1, 0, 1, and 2 are not considered to be magic numbers.
039 * </p>
040 *
041 * <p>Constant definition is any variable/field that has 'final' modifier.
042 * It is fine to have one constant defining multiple numeric literals within one expression:
043 * <pre>
044 * {@code static final int SECONDS_PER_DAY = 24 * 60 * 60;
045 * static final double SPECIAL_RATIO = 4.0 / 3.0;
046 * static final double SPECIAL_SUM = 1 + Math.E;
047 * static final double SPECIAL_DIFFERENCE = 4 - Math.PI;
048 * static final Border STANDARD_BORDER = BorderFactory.createEmptyBorder(3, 3, 3, 3);
049 * static final Integer ANSWER_TO_THE_ULTIMATE_QUESTION_OF_LIFE = new Integer(42);}
050 * </pre>
051 *
052 * <p>Check have following options:
053 * ignoreHashCodeMethod - ignore magic numbers in hashCode methods;
054 * ignoreAnnotation - ignore magic numbers in annotation declarations;
055 * ignoreFieldDeclaration - ignore magic numbers in field declarations.
056 * <p>
057 * To configure the check with default configuration:
058 * </p>
059 * <pre>
060 * &lt;module name=&quot;MagicNumber&quot;/&gt;
061 * </pre>
062 * <p>
063 * results is following violations:
064 * </p>
065 * <pre>
066 * {@code
067 *   {@literal @}MyAnnotation(6) // violation
068 *   class MyClass {
069 *       private field = 7; // violation
070 *
071 *       void foo() {
072 *          int i = i + 1; // no violation
073 *          int j = j + 8; // violation
074 *       }
075 *   }
076 * }
077 * </pre>
078 * <p>
079 * To configure the check so that it checks floating-point numbers
080 * that are not 0, 0.5, or 1:
081 * </p>
082 * <pre>
083 *   &lt;module name=&quot;MagicNumber&quot;&gt;
084 *       &lt;property name=&quot;tokens&quot; value=&quot;NUM_DOUBLE, NUM_FLOAT&quot;/&gt;
085 *       &lt;property name=&quot;ignoreNumbers&quot; value=&quot;0, 0.5, 1&quot;/&gt;
086 *       &lt;property name=&quot;ignoreFieldDeclaration&quot; value=&quot;true&quot;/&gt;
087 *       &lt;property name=&quot;ignoreAnnotation&quot; value=&quot;true&quot;/&gt;
088 *   &lt;/module&gt;
089 * </pre>
090 * <p>
091 * results is following violations:
092 * </p>
093 * <pre>
094 * {@code
095 *   {@literal @}MyAnnotation(6) // no violation
096 *   class MyClass {
097 *       private field = 7; // no violation
098 *
099 *       void foo() {
100 *          int i = i + 1; // no violation
101 *          int j = j + (int)0.5; // no violation
102 *       }
103 *   }
104 * }
105 * </pre>
106 * <p>
107 * Config example of constantWaiverParentToken option:
108 * </p>
109 * <pre>
110 *   &lt;module name=&quot;MagicNumber&quot;&gt;
111 *       &lt;property name=&quot;constantWaiverParentToken&quot; value=&quot;ASSIGN,ARRAY_INIT,EXPR,
112 *       UNARY_PLUS, UNARY_MINUS, TYPECAST, ELIST, DIV, PLUS &quot;/&gt;
113 *   &lt;/module&gt;
114 * </pre>
115 * <p>
116 * result is following violation:
117 * </p>
118 * <pre>
119 * {@code
120 * class TestMethodCall {
121 *     public void method2() {
122 *         final TestMethodCall dummyObject = new TestMethodCall(62);    //violation
123 *         final int a = 3;        // ok as waiver is ASSIGN
124 *         final int [] b = {4, 5} // ok as waiver is ARRAY_INIT
125 *         final int c = -3;       // ok as waiver is UNARY_MINUS
126 *         final int d = +4;       // ok as waiver is UNARY_PLUS
127 *         final int e = method(1, 2) // ELIST is there but violation due to METHOD_CALL
128 *         final int x = 3 * 4;    // violation
129 *         final int y = 3 / 4;    // ok as waiver is DIV
130 *         final int z = 3 + 4;    // ok as waiver is PLUS
131 *         final int w = 3 - 4;    // violation
132 *         final int x = (int)(3.4);    //ok as waiver is TYPECAST
133 *     }
134 * }
135 * }
136 * </pre>
137 */
138@StatelessCheck
139public class MagicNumberCheck extends AbstractCheck {
140
141    /**
142     * A key is pointing to the warning message text in "messages.properties"
143     * file.
144     */
145    public static final String MSG_KEY = "magic.number";
146
147    /**
148     * The token types that are allowed in the AST path from the
149     * number literal to the enclosing constant definition.
150     */
151    private int[] constantWaiverParentToken = {
152        TokenTypes.ASSIGN,
153        TokenTypes.ARRAY_INIT,
154        TokenTypes.EXPR,
155        TokenTypes.UNARY_PLUS,
156        TokenTypes.UNARY_MINUS,
157        TokenTypes.TYPECAST,
158        TokenTypes.ELIST,
159        TokenTypes.LITERAL_NEW,
160        TokenTypes.METHOD_CALL,
161        TokenTypes.STAR,
162        TokenTypes.DIV,
163        TokenTypes.PLUS,
164        TokenTypes.MINUS,
165    };
166
167    /** The numbers to ignore in the check, sorted. */
168    private double[] ignoreNumbers = {-1, 0, 1, 2};
169
170    /** Whether to ignore magic numbers in a hash code method. */
171    private boolean ignoreHashCodeMethod;
172
173    /** Whether to ignore magic numbers in annotation. */
174    private boolean ignoreAnnotation;
175
176    /** Whether to ignore magic numbers in field declaration. */
177    private boolean ignoreFieldDeclaration;
178
179    /**
180     * Constructor for MagicNumber Check.
181     * Sort the allowedTokensBetweenMagicNumberAndConstDef array for binary search.
182     */
183    public MagicNumberCheck() {
184        Arrays.sort(constantWaiverParentToken);
185    }
186
187    @Override
188    public int[] getDefaultTokens() {
189        return getAcceptableTokens();
190    }
191
192    @Override
193    public int[] getAcceptableTokens() {
194        return new int[] {
195            TokenTypes.NUM_DOUBLE,
196            TokenTypes.NUM_FLOAT,
197            TokenTypes.NUM_INT,
198            TokenTypes.NUM_LONG,
199        };
200    }
201
202    @Override
203    public int[] getRequiredTokens() {
204        return CommonUtils.EMPTY_INT_ARRAY;
205    }
206
207    @Override
208    public void visitToken(DetailAST ast) {
209        if ((!ignoreAnnotation || !isChildOf(ast, TokenTypes.ANNOTATION))
210                && !isInIgnoreList(ast)
211                && (!ignoreHashCodeMethod || !isInHashCodeMethod(ast))) {
212            final DetailAST constantDefAST = findContainingConstantDef(ast);
213
214            if (constantDefAST == null) {
215                if (!ignoreFieldDeclaration || !isFieldDeclaration(ast)) {
216                    reportMagicNumber(ast);
217                }
218            }
219            else {
220                final boolean found = isMagicNumberExists(ast, constantDefAST);
221                if (found) {
222                    reportMagicNumber(ast);
223                }
224            }
225        }
226    }
227
228    /**
229     * Is magic number some where at ast tree.
230     * @param ast ast token
231     * @param constantDefAST constant ast
232     * @return true if magic number is present
233     */
234    private boolean isMagicNumberExists(DetailAST ast, DetailAST constantDefAST) {
235        boolean found = false;
236        DetailAST astNode = ast.getParent();
237        while (astNode != constantDefAST) {
238            final int type = astNode.getType();
239            if (Arrays.binarySearch(constantWaiverParentToken, type) < 0) {
240                found = true;
241                break;
242            }
243            astNode = astNode.getParent();
244        }
245        return found;
246    }
247
248    /**
249     * Finds the constant definition that contains aAST.
250     * @param ast the AST
251     * @return the constant def or null if ast is not contained in a constant definition.
252     */
253    private static DetailAST findContainingConstantDef(DetailAST ast) {
254        DetailAST varDefAST = ast;
255        while (varDefAST != null
256                && varDefAST.getType() != TokenTypes.VARIABLE_DEF
257                && varDefAST.getType() != TokenTypes.ENUM_CONSTANT_DEF) {
258            varDefAST = varDefAST.getParent();
259        }
260        DetailAST constantDef = null;
261
262        // no containing variable definition?
263        if (varDefAST != null) {
264            // implicit constant?
265            if (ScopeUtils.isInInterfaceOrAnnotationBlock(varDefAST)
266                    || varDefAST.getType() == TokenTypes.ENUM_CONSTANT_DEF) {
267                constantDef = varDefAST;
268            }
269            else {
270                // explicit constant
271                final DetailAST modifiersAST = varDefAST.findFirstToken(TokenTypes.MODIFIERS);
272
273                if (modifiersAST.findFirstToken(TokenTypes.FINAL) != null) {
274                    constantDef = varDefAST;
275                }
276            }
277        }
278        return constantDef;
279    }
280
281    /**
282     * Reports aAST as a magic number, includes unary operators as needed.
283     * @param ast the AST node that contains the number to report
284     */
285    private void reportMagicNumber(DetailAST ast) {
286        String text = ast.getText();
287        final DetailAST parent = ast.getParent();
288        DetailAST reportAST = ast;
289        if (parent.getType() == TokenTypes.UNARY_MINUS) {
290            reportAST = parent;
291            text = "-" + text;
292        }
293        else if (parent.getType() == TokenTypes.UNARY_PLUS) {
294            reportAST = parent;
295            text = "+" + text;
296        }
297        log(reportAST.getLineNo(),
298                reportAST.getColumnNo(),
299                MSG_KEY,
300                text);
301    }
302
303    /**
304     * Determines whether or not the given AST is in a valid hash code method.
305     * A valid hash code method is considered to be a method of the signature
306     * {@code public int hashCode()}.
307     *
308     * @param ast the AST from which to search for an enclosing hash code
309     *     method definition
310     *
311     * @return {@code true} if {@code ast} is in the scope of a valid hash code method.
312     */
313    private static boolean isInHashCodeMethod(DetailAST ast) {
314        boolean inHashCodeMethod = false;
315
316        // if not in a code block, can't be in hashCode()
317        if (ScopeUtils.isInCodeBlock(ast)) {
318            // find the method definition AST
319            DetailAST methodDefAST = ast.getParent();
320            while (methodDefAST != null
321                    && methodDefAST.getType() != TokenTypes.METHOD_DEF) {
322                methodDefAST = methodDefAST.getParent();
323            }
324
325            if (methodDefAST != null) {
326                // Check for 'hashCode' name.
327                final DetailAST identAST = methodDefAST.findFirstToken(TokenTypes.IDENT);
328
329                if ("hashCode".equals(identAST.getText())) {
330                    // Check for no arguments.
331                    final DetailAST paramAST = methodDefAST.findFirstToken(TokenTypes.PARAMETERS);
332                    // we are in a 'public int hashCode()' method! The compiler will ensure
333                    // the method returns an 'int' and is public.
334                    inHashCodeMethod = paramAST.getChildCount() == 0;
335                }
336            }
337        }
338        return inHashCodeMethod;
339    }
340
341    /**
342     * Decides whether the number of an AST is in the ignore list of this
343     * check.
344     * @param ast the AST to check
345     * @return true if the number of ast is in the ignore list of this check.
346     */
347    private boolean isInIgnoreList(DetailAST ast) {
348        double value = CheckUtils.parseDouble(ast.getText(), ast.getType());
349        final DetailAST parent = ast.getParent();
350        if (parent.getType() == TokenTypes.UNARY_MINUS) {
351            value = -1 * value;
352        }
353        return Arrays.binarySearch(ignoreNumbers, value) >= 0;
354    }
355
356    /**
357     * Determines whether or not the given AST is field declaration.
358     *
359     * @param ast AST from which to search for an enclosing field declaration
360     *
361     * @return {@code true} if {@code ast} is in the scope of field declaration
362     */
363    private static boolean isFieldDeclaration(DetailAST ast) {
364        DetailAST varDefAST = ast;
365        while (varDefAST != null
366                && varDefAST.getType() != TokenTypes.VARIABLE_DEF) {
367            varDefAST = varDefAST.getParent();
368        }
369
370        // contains variable declaration
371        // and it is directly inside class declaration
372        return varDefAST != null
373                && varDefAST.getParent().getParent().getType() == TokenTypes.CLASS_DEF;
374    }
375
376    /**
377     * Sets the tokens which are allowed between Magic Number and defined Object.
378     * @param tokens The string representation of the tokens interested in
379     */
380    public void setConstantWaiverParentToken(String... tokens) {
381        constantWaiverParentToken = new int[tokens.length];
382        for (int i = 0; i < tokens.length; i++) {
383            constantWaiverParentToken[i] = TokenUtils.getTokenId(tokens[i]);
384        }
385        Arrays.sort(constantWaiverParentToken);
386    }
387
388    /**
389     * Sets the numbers to ignore in the check.
390     * BeanUtils converts numeric token list to double array automatically.
391     * @param list list of numbers to ignore.
392     */
393    public void setIgnoreNumbers(double... list) {
394        if (list.length == 0) {
395            ignoreNumbers = CommonUtils.EMPTY_DOUBLE_ARRAY;
396        }
397        else {
398            ignoreNumbers = new double[list.length];
399            System.arraycopy(list, 0, ignoreNumbers, 0, list.length);
400            Arrays.sort(ignoreNumbers);
401        }
402    }
403
404    /**
405     * Set whether to ignore hashCode methods.
406     * @param ignoreHashCodeMethod decide whether to ignore
407     *     hash code methods
408     */
409    public void setIgnoreHashCodeMethod(boolean ignoreHashCodeMethod) {
410        this.ignoreHashCodeMethod = ignoreHashCodeMethod;
411    }
412
413    /**
414     * Set whether to ignore Annotations.
415     * @param ignoreAnnotation decide whether to ignore annotations
416     */
417    public void setIgnoreAnnotation(boolean ignoreAnnotation) {
418        this.ignoreAnnotation = ignoreAnnotation;
419    }
420
421    /**
422     * Set whether to ignore magic numbers in field declaration.
423     * @param ignoreFieldDeclaration decide whether to ignore magic numbers
424     *     in field declaration
425     */
426    public void setIgnoreFieldDeclaration(boolean ignoreFieldDeclaration) {
427        this.ignoreFieldDeclaration = ignoreFieldDeclaration;
428    }
429
430    /**
431     * Determines if the given AST node has a parent node with given token type code.
432     *
433     * @param ast the AST from which to search for annotations
434     * @param type the type code of parent token
435     *
436     * @return {@code true} if the AST node has a parent with given token type.
437     */
438    private static boolean isChildOf(DetailAST ast, int type) {
439        boolean result = false;
440        DetailAST node = ast;
441        do {
442            if (node.getType() == type) {
443                result = true;
444                break;
445            }
446            node = node.getParent();
447        } while (node != null);
448
449        return result;
450    }
451
452}