com.qulice.pmd.rules

Class UseStringIsEmptyRule

java.lang.Object

net.sourceforge.pmd.properties.AbstractPropertySource

net.sourceforge.pmd.lang.rule.AbstractRule

net.sourceforge.pmd.lang.java.rule.AbstractJavaRule

net.sourceforge.pmd.lang.java.rule.AbstractInefficientZeroCheck

com.qulice.pmd.rules.UseStringIsEmptyRule

All Implemented Interfaces:

net.sourceforge.pmd.lang.java.ast.JavaParserVisitor, net.sourceforge.pmd.lang.rule.ImmutableLanguage, net.sourceforge.pmd.properties.PropertySource, net.sourceforge.pmd.Rule

public final class UseStringIsEmptyRule
extends net.sourceforge.pmd.lang.java.rule.AbstractInefficientZeroCheck

Rule to prohibit use of String.length() when checking for empty string. String.isEmpty() should be used instead.

Since:

0.18

todo:

#801:30min This rule currently doesn't complain if the string is prefixed with this when length is called (e.g. somestring.length() works but this.somestring.length() does not). The same happens in with a method call (this.method().length() does not work). Check if possible and if it is, extend this rule to also catch this case. More about how to write PMD rules here: http://pmd.sourceforge.net/pmd-4.3/howtowritearule.html.

Field Summary

Fields inherited from class net.sourceforge.pmd.properties.AbstractPropertySource

propertyDescriptors, propertyValuesByDescriptor

Fields inherited from interface net.sourceforge.pmd.Rule

VIOLATION_SUPPRESS_REGEX_DESCRIPTOR, VIOLATION_SUPPRESS_XPATH_DESCRIPTOR

Constructor Summary

Constructors

Constructor and Description
UseStringIsEmptyRule()

Method Summary

Modifier and Type	Method and Description
boolean	appliesToClassName(java.lang.String name)
java.util.Map<java.lang.String,java.util.List<java.lang.String>>	getComparisonTargets()
boolean	isTargetMethod(net.sourceforge.pmd.lang.java.symboltable.JavaNameOccurrence occ)
java.lang.Object	visit(net.sourceforge.pmd.lang.java.ast.ASTPrimarySuffix node, java.lang.Object data)

Methods inherited from class net.sourceforge.pmd.lang.java.rule.AbstractInefficientZeroCheck

checkNodeAndReport, visit

Methods inherited from class net.sourceforge.pmd.lang.java.rule.AbstractJavaRule

apply, getDeclaringType, importsPackage, isQualifiedName, isSuppressed, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visitAll

Methods inherited from class net.sourceforge.pmd.lang.rule.AbstractRule

addExample, addRuleChainVisit, addRuleChainVisit, addViolation, addViolation, addViolation, addViolationWithMessage, addViolationWithMessage, addViolationWithMessage, deepCopy, deepCopyValuesTo, end, equals, getDescription, getExamples, getExternalInfoUrl, getLanguage, getMaximumLanguageVersion, getMessage, getMinimumLanguageVersion, getName, getParserOptions, getPriority, getRuleChainVisits, getRuleClass, getRuleSetName, getSince, hashCode, isDeprecated, isDfa, isMultifile, isRuleChain, isTypeResolution, setDeprecated, setDescription, setDfa, setExternalInfoUrl, setLanguage, setMaximumLanguageVersion, setMessage, setMinimumLanguageVersion, setMultifile, setName, setPriority, setRuleClass, setRuleSetName, setSince, setTypeResolution, setUsesDFA, setUsesMultifile, setUsesTypeResolution, start, usesDFA, usesMultifile, usesRuleChain, usesTypeResolution

Methods inherited from class net.sourceforge.pmd.properties.AbstractPropertySource

copyPropertyDescriptors, copyPropertyValues, definePropertyDescriptor, dysfunctionReason, getPropertiesByPropertyDescriptor, getProperty, getPropertyDescriptor, getPropertyDescriptors, hasDescriptor, ignoredProperties, setProperty, setProperty, useDefaultValueFor, usesDefaultValues

Methods inherited from class java.lang.Object

clone, finalize, getClass, notify, notifyAll, toString, wait, wait, wait

Methods inherited from interface net.sourceforge.pmd.properties.PropertySource

definePropertyDescriptor, dysfunctionReason, getPropertiesByPropertyDescriptor, getProperty, getPropertyDescriptor, getPropertyDescriptors, hasDescriptor, ignoredProperties, setProperty, setProperty, useDefaultValueFor, usesDefaultValues

Constructor Detail

UseStringIsEmptyRule

public UseStringIsEmptyRule()

Method Detail

appliesToClassName

public boolean appliesToClassName(java.lang.String name)

Specified by:

appliesToClassName in class net.sourceforge.pmd.lang.java.rule.AbstractInefficientZeroCheck

getComparisonTargets

public java.util.Map<java.lang.String,java.util.List<java.lang.String>> getComparisonTargets()

Overrides:

getComparisonTargets in class net.sourceforge.pmd.lang.java.rule.AbstractInefficientZeroCheck

isTargetMethod

public boolean isTargetMethod(net.sourceforge.pmd.lang.java.symboltable.JavaNameOccurrence occ)

Specified by:

isTargetMethod in class net.sourceforge.pmd.lang.java.rule.AbstractInefficientZeroCheck

visit

public java.lang.Object visit(net.sourceforge.pmd.lang.java.ast.ASTPrimarySuffix node,
                              java.lang.Object data)

Specified by:

visit in interface net.sourceforge.pmd.lang.java.ast.JavaParserVisitor

Overrides:

visit in class net.sourceforge.pmd.lang.java.rule.AbstractJavaRule