public class InnerAssignmentCheck extends AbstractCheck
Checks for assignments in subexpressions, such as in
String s = Integer.toString(i = 2);.
Rationale: With the exception of for iterators and assignment in while idiom,
all assignments should occur in their own top-level statement to increase readability.
With inner assignments like the one given above, it is difficult to see all places
where a variable is set.
Note: Check allows usage of the popular assignment in while idiom:
String line;
while ((line = bufferedReader.readLine()) != null) {
// process the line
}
Assignment inside a condition is not a problem here, as the assignment is surrounded
by an extra pair of parentheses. The comparison is != null and there is no chance that
intention was to write line == reader.readLine().
To configure the check:
<module name="InnerAssignment"/>
AutomaticBean.OutputStreamOptions| Modifier and Type | Field and Description |
|---|---|
static java.lang.String |
MSG_KEY
A key is pointing to the warning message text in "messages.properties"
file.
|
| Constructor and Description |
|---|
InnerAssignmentCheck() |
| Modifier and Type | Method and Description |
|---|---|
int[] |
getAcceptableTokens()
The configurable token set.
|
int[] |
getDefaultTokens()
Returns the default token a check is interested in.
|
int[] |
getRequiredTokens()
The tokens that this check must be registered for.
|
void |
visitToken(DetailAST ast)
Called to process a token.
|
beginTree, clearMessages, destroy, finishTree, getFileContents, getLine, getLines, getMessages, getTabWidth, getTokenNames, init, isCommentNodesRequired, leaveToken, log, log, log, setFileContents, setTabWidth, setTokensfinishLocalSetup, getCustomMessages, getId, getMessageBundle, getSeverity, getSeverityLevel, setId, setSeverityconfigure, contextualize, getConfiguration, setupChildpublic static final java.lang.String MSG_KEY
public InnerAssignmentCheck()
public int[] getDefaultTokens()
AbstractCheckgetDefaultTokens in class AbstractCheckTokenTypespublic int[] getAcceptableTokens()
AbstractCheckgetAcceptableTokens in class AbstractCheckTokenTypespublic int[] getRequiredTokens()
AbstractCheckgetRequiredTokens in class AbstractCheckTokenTypespublic void visitToken(DetailAST ast)
AbstractCheckvisitToken in class AbstractCheckast - the token to processCopyright © 2001-2020. All Rights Reserved.