001//////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code for adherence to a set of rules. 003// Copyright (C) 2001-2018 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018//////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.coding; 021 022import java.util.Arrays; 023 024import com.puppycrawl.tools.checkstyle.StatelessCheck; 025import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 026import com.puppycrawl.tools.checkstyle.api.DetailAST; 027import com.puppycrawl.tools.checkstyle.api.TokenTypes; 028import com.puppycrawl.tools.checkstyle.utils.CheckUtil; 029import com.puppycrawl.tools.checkstyle.utils.CommonUtil; 030import com.puppycrawl.tools.checkstyle.utils.ScopeUtil; 031import com.puppycrawl.tools.checkstyle.utils.TokenUtil; 032 033/** 034 * <p> 035 * Checks that there are no <a href="https://en.wikipedia.org/wiki/Magic_number_%28programming%29"> 036 * "magic numbers"</a> where a magic 037 * number is a numeric literal that is not defined as a constant. 038 * By default, -1, 0, 1, and 2 are not considered to be magic numbers. 039 * </p> 040 * 041 * <p>Constant definition is any variable/field that has 'final' modifier. 042 * It is fine to have one constant defining multiple numeric literals within one expression: 043 * <pre> 044 * {@code static final int SECONDS_PER_DAY = 24 * 60 * 60; 045 * static final double SPECIAL_RATIO = 4.0 / 3.0; 046 * static final double SPECIAL_SUM = 1 + Math.E; 047 * static final double SPECIAL_DIFFERENCE = 4 - Math.PI; 048 * static final Border STANDARD_BORDER = BorderFactory.createEmptyBorder(3, 3, 3, 3); 049 * static final Integer ANSWER_TO_THE_ULTIMATE_QUESTION_OF_LIFE = new Integer(42);} 050 * </pre> 051 * 052 * <p>Check have following options: 053 * ignoreHashCodeMethod - ignore magic numbers in hashCode methods; 054 * ignoreAnnotation - ignore magic numbers in annotation declarations; 055 * ignoreFieldDeclaration - ignore magic numbers in field declarations. 056 * <p> 057 * To configure the check with default configuration: 058 * </p> 059 * <pre> 060 * <module name="MagicNumber"/> 061 * </pre> 062 * <p> 063 * results is following violations: 064 * </p> 065 * <pre> 066 * {@code 067 * {@literal @}MyAnnotation(6) // violation 068 * class MyClass { 069 * private field = 7; // violation 070 * 071 * void foo() { 072 * int i = i + 1; // no violation 073 * int j = j + 8; // violation 074 * } 075 * } 076 * } 077 * </pre> 078 * <p> 079 * To configure the check so that it checks floating-point numbers 080 * that are not 0, 0.5, or 1: 081 * </p> 082 * <pre> 083 * <module name="MagicNumber"> 084 * <property name="tokens" value="NUM_DOUBLE, NUM_FLOAT"/> 085 * <property name="ignoreNumbers" value="0, 0.5, 1"/> 086 * <property name="ignoreFieldDeclaration" value="true"/> 087 * <property name="ignoreAnnotation" value="true"/> 088 * </module> 089 * </pre> 090 * <p> 091 * results is following violations: 092 * </p> 093 * <pre> 094 * {@code 095 * {@literal @}MyAnnotation(6) // no violation 096 * class MyClass { 097 * private field = 7; // no violation 098 * 099 * void foo() { 100 * int i = i + 1; // no violation 101 * int j = j + (int)0.5; // no violation 102 * } 103 * } 104 * } 105 * </pre> 106 * <p> 107 * Config example of constantWaiverParentToken option: 108 * </p> 109 * <pre> 110 * <module name="MagicNumber"> 111 * <property name="constantWaiverParentToken" value="ASSIGN,ARRAY_INIT,EXPR, 112 * UNARY_PLUS, UNARY_MINUS, TYPECAST, ELIST, DIV, PLUS "/> 113 * </module> 114 * </pre> 115 * <p> 116 * result is following violation: 117 * </p> 118 * <pre> 119 * {@code 120 * class TestMethodCall { 121 * public void method2() { 122 * final TestMethodCall dummyObject = new TestMethodCall(62); //violation 123 * final int a = 3; // ok as waiver is ASSIGN 124 * final int [] b = {4, 5} // ok as waiver is ARRAY_INIT 125 * final int c = -3; // ok as waiver is UNARY_MINUS 126 * final int d = +4; // ok as waiver is UNARY_PLUS 127 * final int e = method(1, 2) // ELIST is there but violation due to METHOD_CALL 128 * final int x = 3 * 4; // violation 129 * final int y = 3 / 4; // ok as waiver is DIV 130 * final int z = 3 + 4; // ok as waiver is PLUS 131 * final int w = 3 - 4; // violation 132 * final int x = (int)(3.4); //ok as waiver is TYPECAST 133 * } 134 * } 135 * } 136 * </pre> 137 */ 138@StatelessCheck 139public class MagicNumberCheck extends AbstractCheck { 140 141 /** 142 * A key is pointing to the warning message text in "messages.properties" 143 * file. 144 */ 145 public static final String MSG_KEY = "magic.number"; 146 147 /** 148 * The token types that are allowed in the AST path from the 149 * number literal to the enclosing constant definition. 150 */ 151 private int[] constantWaiverParentToken = { 152 TokenTypes.ASSIGN, 153 TokenTypes.ARRAY_INIT, 154 TokenTypes.EXPR, 155 TokenTypes.UNARY_PLUS, 156 TokenTypes.UNARY_MINUS, 157 TokenTypes.TYPECAST, 158 TokenTypes.ELIST, 159 TokenTypes.LITERAL_NEW, 160 TokenTypes.METHOD_CALL, 161 TokenTypes.STAR, 162 TokenTypes.DIV, 163 TokenTypes.PLUS, 164 TokenTypes.MINUS, 165 }; 166 167 /** The numbers to ignore in the check, sorted. */ 168 private double[] ignoreNumbers = {-1, 0, 1, 2}; 169 170 /** Whether to ignore magic numbers in a hash code method. */ 171 private boolean ignoreHashCodeMethod; 172 173 /** Whether to ignore magic numbers in annotation. */ 174 private boolean ignoreAnnotation; 175 176 /** Whether to ignore magic numbers in field declaration. */ 177 private boolean ignoreFieldDeclaration; 178 179 /** 180 * Constructor for MagicNumber Check. 181 * Sort the allowedTokensBetweenMagicNumberAndConstDef array for binary search. 182 */ 183 public MagicNumberCheck() { 184 Arrays.sort(constantWaiverParentToken); 185 } 186 187 @Override 188 public int[] getDefaultTokens() { 189 return getAcceptableTokens(); 190 } 191 192 @Override 193 public int[] getAcceptableTokens() { 194 return new int[] { 195 TokenTypes.NUM_DOUBLE, 196 TokenTypes.NUM_FLOAT, 197 TokenTypes.NUM_INT, 198 TokenTypes.NUM_LONG, 199 }; 200 } 201 202 @Override 203 public int[] getRequiredTokens() { 204 return CommonUtil.EMPTY_INT_ARRAY; 205 } 206 207 @Override 208 public void visitToken(DetailAST ast) { 209 if ((!ignoreAnnotation || !isChildOf(ast, TokenTypes.ANNOTATION)) 210 && !isInIgnoreList(ast) 211 && (!ignoreHashCodeMethod || !isInHashCodeMethod(ast))) { 212 final DetailAST constantDefAST = findContainingConstantDef(ast); 213 214 if (constantDefAST == null) { 215 if (!ignoreFieldDeclaration || !isFieldDeclaration(ast)) { 216 reportMagicNumber(ast); 217 } 218 } 219 else { 220 final boolean found = isMagicNumberExists(ast, constantDefAST); 221 if (found) { 222 reportMagicNumber(ast); 223 } 224 } 225 } 226 } 227 228 /** 229 * Is magic number some where at ast tree. 230 * @param ast ast token 231 * @param constantDefAST constant ast 232 * @return true if magic number is present 233 */ 234 private boolean isMagicNumberExists(DetailAST ast, DetailAST constantDefAST) { 235 boolean found = false; 236 DetailAST astNode = ast.getParent(); 237 while (astNode != constantDefAST) { 238 final int type = astNode.getType(); 239 if (Arrays.binarySearch(constantWaiverParentToken, type) < 0) { 240 found = true; 241 break; 242 } 243 astNode = astNode.getParent(); 244 } 245 return found; 246 } 247 248 /** 249 * Finds the constant definition that contains aAST. 250 * @param ast the AST 251 * @return the constant def or null if ast is not contained in a constant definition. 252 */ 253 private static DetailAST findContainingConstantDef(DetailAST ast) { 254 DetailAST varDefAST = ast; 255 while (varDefAST != null 256 && varDefAST.getType() != TokenTypes.VARIABLE_DEF 257 && varDefAST.getType() != TokenTypes.ENUM_CONSTANT_DEF) { 258 varDefAST = varDefAST.getParent(); 259 } 260 DetailAST constantDef = null; 261 262 // no containing variable definition? 263 if (varDefAST != null) { 264 // implicit constant? 265 if (ScopeUtil.isInInterfaceOrAnnotationBlock(varDefAST) 266 || varDefAST.getType() == TokenTypes.ENUM_CONSTANT_DEF) { 267 constantDef = varDefAST; 268 } 269 else { 270 // explicit constant 271 final DetailAST modifiersAST = varDefAST.findFirstToken(TokenTypes.MODIFIERS); 272 273 if (modifiersAST.findFirstToken(TokenTypes.FINAL) != null) { 274 constantDef = varDefAST; 275 } 276 } 277 } 278 return constantDef; 279 } 280 281 /** 282 * Reports aAST as a magic number, includes unary operators as needed. 283 * @param ast the AST node that contains the number to report 284 */ 285 private void reportMagicNumber(DetailAST ast) { 286 String text = ast.getText(); 287 final DetailAST parent = ast.getParent(); 288 DetailAST reportAST = ast; 289 if (parent.getType() == TokenTypes.UNARY_MINUS) { 290 reportAST = parent; 291 text = "-" + text; 292 } 293 else if (parent.getType() == TokenTypes.UNARY_PLUS) { 294 reportAST = parent; 295 text = "+" + text; 296 } 297 log(reportAST, 298 MSG_KEY, 299 text); 300 } 301 302 /** 303 * Determines whether or not the given AST is in a valid hash code method. 304 * A valid hash code method is considered to be a method of the signature 305 * {@code public int hashCode()}. 306 * 307 * @param ast the AST from which to search for an enclosing hash code 308 * method definition 309 * 310 * @return {@code true} if {@code ast} is in the scope of a valid hash code method. 311 */ 312 private static boolean isInHashCodeMethod(DetailAST ast) { 313 boolean inHashCodeMethod = false; 314 315 // if not in a code block, can't be in hashCode() 316 if (ScopeUtil.isInCodeBlock(ast)) { 317 // find the method definition AST 318 DetailAST methodDefAST = ast.getParent(); 319 while (methodDefAST != null 320 && methodDefAST.getType() != TokenTypes.METHOD_DEF) { 321 methodDefAST = methodDefAST.getParent(); 322 } 323 324 if (methodDefAST != null) { 325 // Check for 'hashCode' name. 326 final DetailAST identAST = methodDefAST.findFirstToken(TokenTypes.IDENT); 327 328 if ("hashCode".equals(identAST.getText())) { 329 // Check for no arguments. 330 final DetailAST paramAST = methodDefAST.findFirstToken(TokenTypes.PARAMETERS); 331 // we are in a 'public int hashCode()' method! The compiler will ensure 332 // the method returns an 'int' and is public. 333 inHashCodeMethod = paramAST.getChildCount() == 0; 334 } 335 } 336 } 337 return inHashCodeMethod; 338 } 339 340 /** 341 * Decides whether the number of an AST is in the ignore list of this 342 * check. 343 * @param ast the AST to check 344 * @return true if the number of ast is in the ignore list of this check. 345 */ 346 private boolean isInIgnoreList(DetailAST ast) { 347 double value = CheckUtil.parseDouble(ast.getText(), ast.getType()); 348 final DetailAST parent = ast.getParent(); 349 if (parent.getType() == TokenTypes.UNARY_MINUS) { 350 value = -1 * value; 351 } 352 return Arrays.binarySearch(ignoreNumbers, value) >= 0; 353 } 354 355 /** 356 * Determines whether or not the given AST is field declaration. 357 * 358 * @param ast AST from which to search for an enclosing field declaration 359 * 360 * @return {@code true} if {@code ast} is in the scope of field declaration 361 */ 362 private static boolean isFieldDeclaration(DetailAST ast) { 363 DetailAST varDefAST = ast; 364 while (varDefAST != null 365 && varDefAST.getType() != TokenTypes.VARIABLE_DEF) { 366 varDefAST = varDefAST.getParent(); 367 } 368 369 // contains variable declaration 370 // and it is directly inside class declaration 371 return varDefAST != null 372 && varDefAST.getParent().getParent().getType() == TokenTypes.CLASS_DEF; 373 } 374 375 /** 376 * Sets the tokens which are allowed between Magic Number and defined Object. 377 * @param tokens The string representation of the tokens interested in 378 */ 379 public void setConstantWaiverParentToken(String... tokens) { 380 constantWaiverParentToken = new int[tokens.length]; 381 for (int i = 0; i < tokens.length; i++) { 382 constantWaiverParentToken[i] = TokenUtil.getTokenId(tokens[i]); 383 } 384 Arrays.sort(constantWaiverParentToken); 385 } 386 387 /** 388 * Sets the numbers to ignore in the check. 389 * BeanUtils converts numeric token list to double array automatically. 390 * @param list list of numbers to ignore. 391 */ 392 public void setIgnoreNumbers(double... list) { 393 if (list.length == 0) { 394 ignoreNumbers = CommonUtil.EMPTY_DOUBLE_ARRAY; 395 } 396 else { 397 ignoreNumbers = new double[list.length]; 398 System.arraycopy(list, 0, ignoreNumbers, 0, list.length); 399 Arrays.sort(ignoreNumbers); 400 } 401 } 402 403 /** 404 * Set whether to ignore hashCode methods. 405 * @param ignoreHashCodeMethod decide whether to ignore 406 * hash code methods 407 */ 408 public void setIgnoreHashCodeMethod(boolean ignoreHashCodeMethod) { 409 this.ignoreHashCodeMethod = ignoreHashCodeMethod; 410 } 411 412 /** 413 * Set whether to ignore Annotations. 414 * @param ignoreAnnotation decide whether to ignore annotations 415 */ 416 public void setIgnoreAnnotation(boolean ignoreAnnotation) { 417 this.ignoreAnnotation = ignoreAnnotation; 418 } 419 420 /** 421 * Set whether to ignore magic numbers in field declaration. 422 * @param ignoreFieldDeclaration decide whether to ignore magic numbers 423 * in field declaration 424 */ 425 public void setIgnoreFieldDeclaration(boolean ignoreFieldDeclaration) { 426 this.ignoreFieldDeclaration = ignoreFieldDeclaration; 427 } 428 429 /** 430 * Determines if the given AST node has a parent node with given token type code. 431 * 432 * @param ast the AST from which to search for annotations 433 * @param type the type code of parent token 434 * 435 * @return {@code true} if the AST node has a parent with given token type. 436 */ 437 private static boolean isChildOf(DetailAST ast, int type) { 438 boolean result = false; 439 DetailAST node = ast; 440 do { 441 if (node.getType() == type) { 442 result = true; 443 break; 444 } 445 node = node.getParent(); 446 } while (node != null); 447 448 return result; 449 } 450 451}